search

andrevdm / postgresql-migration

PostgreSQL Schema Migrations for Haskell
Other
15 stars 4 forks source link

Add log statement before executing file #13

Closed jappeace closed 2 years ago

jappeace commented 2 years ago

If a script throws an exception, you know exactly now which one was running.

jappeace commented 2 years ago

@andrevdm could you please review this?

andrevdm commented 2 years ago

Wow, sorry, I seem to have missed all of those notifications. Looking now

andrevdm commented 2 years ago

@jappeace I've added a comment for a very minor style issue. Other than that it looks like a good idea to me.

The only potential issue I could imagine is that someone is tracking the log output and that may break after this change... but I'm not convinced that is a reasonable concern. Logs can always change, so that would just have to be handled.

jappeace commented 2 years ago

@andrevdm is your style comment still in a pending review? it's not showing up for me.

andrevdm commented 2 years ago

@jappeace I had indeed, not clicked the button

andrevdm commented 2 years ago

Merged, I'll update hackage a bit later

andrevdm commented 2 years ago

And thanks for the PR :)

andrevdm commented 2 years ago

0.2.1.4 uploaded to hackage

jappeace commented 2 years ago

Thanks, nice!