search

andrew-bibb / cmst

QT GUI for Connman
174 stars 37 forks source link

Preferences look strange if advanced controls enabled #129

Closed agaida closed 8 years ago

agaida commented 8 years ago

http://i.imgur.com/1k7wN64.png - make the window bigger per default would fix that

andrew-bibb commented 8 years ago

Looks like I didn't put those into a layout, should be fairly to fix. Thanks for finding it, as without a layout it probably does the same thing if you try to shrink the window by dragging the lower right corner up.

Edit: Actually this may be a bit more complicated than I thought. Those lines are in a layout so that should not be happening. Stay tuned....

andrew-bibb commented 8 years ago

Bit more complicated was right. I've got some code up on GitHub now that may address this. I fear though I may have broken the small screen fix I put in a couple of weeks ago. If you get a chance to look and see how the current runs I'd appreciate it.

andrew-bibb commented 8 years ago

I may have it now. I added a scroll area to the Preferences tab and removed the fixed size layout (my previous try). I think this will do it both for your issue and the older display properly on small screens issue. Code is now here on GitHub.

I'm going to leave this open for another day or two as I may want to do the same on one additional tab. Other than that I think it is done.

agaida commented 8 years ago

looks fine i think - great work so far. Thank you.

andrew-bibb commented 8 years ago

Great. I'm going to close this out for now. If it comes back or you find something similar feel free to reopen or start a new issue.

I did add scroll areas to a couple of the other tab panes. The behavior (expand and shrink) now is more consistent across panes so overall it is better.