search

andrew-bibb / cmst

QT GUI for Connman
174 stars 37 forks source link

Allow modification of profiles #19

Closed progandy closed 10 years ago

progandy commented 10 years ago

It would be great if you would implement a dialog to set static network settings for wired and wireless connections. Maybe also allow to store static profiles for the ethernet connection. And I noticed that it is difficult to connect to an access point with hidden ssid, is there a way to allow creation of a matching profile? (Update: works with current version)

andrew-bibb commented 10 years ago

I've marked this as an 'enhancement' for now. I'm intending this program to be a real front end for connman, so if connman will let us create or edit static profiles I can write the dialogs for it. I'm a little hesitant at the moment as I don't recall seeing that in the API documents, but on the other hand the API is constantly being expanded and I've not implemented all of it by any means.

On the hidden ssid (I unfortunately don't have access to one to test with); did the connection not show up in the service or wifi boxes? The agent dialog is supposed to enable and disable sections as necessary depending on what is needed. For hidden networks the ssid field in the agent dialog should have been enabled. Do you recall that happening?

progandy commented 10 years ago

Connman already has an API to edit existing services, connmanctl supports it. In DBUS it is available via net.connman.Service, the properties named *.Configuration can be modified. You can set the ip config for each service (all wifi ssids and exactly once for an ethernet device). That there are no profiles for ethernet is a bit frustrating, but workable. I have a few scripts for connmanctl that I use to change ethernet networks between home (static), university (dhcp) and so on.

The hidden SSID works now. I guess I had an old cmst version and forgot to check again after the update.

andrew-bibb commented 10 years ago

Excellent. I Never tried editing a profile with connmanctl. If it can be done there I should be able to create the dialogs.

andrew-bibb commented 10 years ago

I've started blocking out the code for this in my head, and I'll probably start sketching on the UI starting next week. Question time, is there anything specific in what you think the UI should be? My thoughts right now are a tabbed dialog or toolbox (really the same functionallity as a tabbed dialog just a different feel). I've used toolboxes in other projects and I like them. Basically one tab or toolbox page for Timeservers, one for Nameservers, one for IPv4, etc.

Real simple to put in a request at this stage so if you have an opinion on something let me know.

Turns out I need to do everything from the net.connman.Service interface. I blew by it when I did the initial version of the program, but it is all there in black and white. I've spent a lot of time last few months with net.connman.Service (mostly the signals part of it) so I don't think this will be super difficult.

andrew-bibb commented 10 years ago

Just uploaded a version (14.08.10-1) with the profile editor dialog fully functional. If someone wants to download and test I'd appreciate it.

andrew-bibb commented 10 years ago

just uploaded some fixes to the previous. The dialog entries are seeded with the previous entries and the values are only written if they actually changed while the dialog was up.

andrew-bibb commented 10 years ago

Implemented in release 2014.08.23