search

andrew-bibb / cmst

QT GUI for Connman
173 stars 37 forks source link

Fix compile on QT6 #278

Closed kitsnotes closed 1 year ago

kitsnotes commented 1 year ago

This is my very basic patch to port cmst to QT6. It did not require much, I did not touch translation warnings, but it is enough to get it to compile and run on QT6.

andrew-bibb commented 1 year ago

Thank you for tackling this. I didn't do a formal pull but rather I went line by line using your PR to make changes in my local version to see what we were doing. Shortcoming of mine, I can look at a computer screen all day long but to really understand something I actually need to type it. You got all of the critical issues and I've also fixed up an additional handful of compiler warnings. I've credited your PR in the change log.

Thank you again for doing this, saved me a ton of time.

A-

kitsnotes commented 1 year ago

glad to hear it was helpful Andrew! the port was hasty on my end as once I got it building on Qt6 I started morphing it into my needs for https://github.com/kitsnotes/hollywood - so glad you were able to spruce it up and fix those warnings :) <3 ~cat