search

andrew-bierman / PackRat

PackRat is a versatile adventure planner tailored for outdoor enthusiasts. It simplifies the process of organizing trips from a simple day hike to cross-country journeys.
https://packrat.world/
Other
15 stars 33 forks source link

Ratpack UI testing in trips page #355

Closed witehound closed 8 months ago

witehound commented 9 months ago

This was very hectic work! please leave a review

render[bot] commented 9 months ago

Your Render PR Server URL is https://packrat-dev-pr-355.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cjq55docfp5c73ejl260.

render[bot] commented 9 months ago

Your Render PR Server at https://packrat-dev-pr-355.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-cjq55docfp5c73ejl260.

andrew-bierman commented 9 months ago

The name is PackRat not RatPack

andrew-bierman commented 9 months ago

Font looks strange on my side ? It somehow went to a times new roman style font

andrew-bierman commented 9 months ago

The actual packrat ui components looks like you just re-exported tamagui for each one?

andrew-bierman commented 9 months ago

Search input is not fitting properly and looks worse than how we had it previously

andrew-bierman commented 9 months ago

Dropdown component could be good ?

witehound commented 9 months ago

@andrew-bierman yes i was expecting comments like this, so i had to import the ratpack ui like that because sometimes the object itself is needed instead of just a component i was looking to talk this over with you! so sorry about the naming issue, so unlike native base tamagui does not support things like placing an object in input so i had to be creative and use just css! we just have to decide on how to proceed from here

andrew-bierman commented 8 months ago

So you would just re-export all the tamagui components we would use, and then pretty much redo UI using tamagui is that correct ? just trying to understand your approach. I assume for things like cards we might want to add some of our own props to simplify this

witehound commented 8 months ago

@andrew-bierman yes! That’s what I’ve done for now it’s written this way for constant improvement as agreed!

andrew-bierman commented 8 months ago
witehound commented 8 months ago

@andrew-bierman fixed all

render[bot] commented 8 months ago

A deploy for your Render PR Server at https://packrat-dev-pr-355.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/web/srv-cjq55docfp5c73ejl260.

render[bot] commented 8 months ago

A deploy for your Render PR Server at https://packrat-dev-pr-355.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/web/srv-cjq55docfp5c73ejl260.

render[bot] commented 8 months ago

A deploy for your Render PR Server at https://packrat-dev-pr-355.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/web/srv-cjq55docfp5c73ejl260.