search

andrew-bierman / PackRat

PackRat is a versatile adventure planner tailored for outdoor enthusiasts. It simplifies the process of organizing trips from a simple day hike to cross-country journeys.
https://packrat.world/
Other
15 stars 33 forks source link

Fixing Pack Addition Error and Adding Copy Feature #882

Open EngrAJ8888 opened 2 weeks ago

EngrAJ8888 commented 2 weeks ago

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Visit the URL: https://packrat.pages.dev
  2. Log in to your account with the following credentials: Email: zoot3@email.com Password: 12345678
  3. Click on the "Create a pack" option, under quick actions.
  4. Begin adding items to your pack
  5. Select 'Calculate Score'

Expected behavior

  1. Users should be able to edit global items they've cloned/added to their pack, and any changes from the global items should not affect the items on the user's pack.
  2. Added items retains unless the user chooses to delete them.
Isthisanmol commented 2 weeks ago

Hi @andrew-bierman, @EngrAJ8888 , I am getting an error on adding item to pack: ""error":{"message":"D1_ERROR: table item has no column named owner_id","code":-32603" I think this is related to database. Screenshot from 2024-05-03 19-11-04

EngrAJ8888 commented 1 week ago

Hi @Isthisanmol, I've checked the live version, and two items are already fixed. The only task left is to add the copy option. Thank you for working on this one! :)

Isthisanmol commented 1 week ago

Hi @EngrAJ8888, I have checked the second issue on native. It was not working as expected so I fixed it on native. Please check PR: #900 and tell me if any issues or updates.Thanks.

EngrAJ8888 commented 1 week ago

Hi @Isthisanmol , thank you for making the updates!

I'd also like to add this item to the list of needed updates:

image Please see photo above - it only stays on this page.

jeweltee commented 1 week ago

hi @Isthisanmol I want to add this also:

Isthisanmol commented 1 week ago

Hi @Isthisanmol , thank you for making the updates!

I'd also like to add this item to the list of needed updates:

* [ ]  Fix the pack creation view feature. Currently, after clicking 'Add Pack', users remain on the same page instead of being directed to the Pack Creation page as expected. Consequently, users are required to navigate to the 'Pack' menu to edit newly added packs.

image Please see photo above - it only stays on this page.

Hi @EngrAJ8888, Please check PR: #906 for the above issue and tell me if any issues or updates.

Isthisanmol commented 1 week ago

hi @Isthisanmol I want to add this also:

* [ ]  The 'edit' option for items in the old packs created is missing, but it's available for the newly created packs.
  please see images below, Thanks!

Screenshot 2024-05-07 at 21 10 26 Screenshot 2024-05-07 at 21 10 03

Hi @jeweltee, I've checked this. It's not a matter of a new pack v/s an old pack. The owner of the item has the exclusive ability to edit it. When I compare two different items from the same pack, I notice that one only offers the option to delete it, while the other provides both options. This is because I am the owner of the second item, not the first one. Hence, I see both options only for the second item. I'll attach screenshots of both items for reference. 2 1

Isthisanmol commented 1 week ago

And also @jeweltee Please check PR: #907. The dropdown for edit and delete of items was not working on native. Therefore, I fixed it. Let me know if any issues or updates. Thanks.

EngrAJ8888 commented 1 week ago

Hi @Isthisanmol , thank you for making the updates! I'd also like to add this item to the list of needed updates:

* [ ]  Fix the pack creation view feature. Currently, after clicking 'Add Pack', users remain on the same page instead of being directed to the Pack Creation page as expected. Consequently, users are required to navigate to the 'Pack' menu to edit newly added packs.

image Please see photo above - it only stays on this page.

Hi @EngrAJ8888, Please check PR: #906 for the above issue and tell me if any issues or updates.

Hi @Isthisanmol - The PR has already been merged, and I noticed that the edit and delete options for items in the pack are no longer working. Could you please take a look into it as well? Thanks!

Isthisanmol commented 1 week ago

Hi @EngrAJ8888, please check PR: #918 and let me know if any issues or updates.

Isthisanmol commented 6 days ago

Hi @EngrAJ8888, please check PR:#926 for the edit and delete options for items in pack and let me know if any issues or updates.

EngrAJ8888 commented 5 days ago

Hi @Isthisanmol, just wanted to let you know that I've added a comment on the PR. Thanks for making the updates!

Isthisanmol commented 5 days ago

Hi @EngrAJ8888, please check PR: #918 and let me know if any issues or updates.

Any issues in this?

Isthisanmol commented 4 days ago

Hi @EngrAJ8888, please check PR: #930. I think it resolves the edit options issue. Let me know if edit option is still not working after first edit.

Isthisanmol commented 2 days ago

Hi @jeweltee @EngrAJ8888 , please check #937. Let me know if the issue persists.

EngrAJ8888 commented 1 day ago

Hi @Isthisanmol , I think there's some confusion about the update needed. The "Copy Pack" feature should be available when the owner browses packs created by other users, not on their own packs. The owner can clone packs from the Feed page and can modify the items in the cloned pack as well. Thanks!

Isthisanmol commented 1 day ago

Hi @Isthisanmol , I think there's some confusion about the update needed. The "Copy Pack" feature should be available when the owner browses packs created by other users, not on their own packs. The owner can clone packs from the Feed page and can modify the items in the cloned pack as well. Thanks!

Should the other options on item and pack also work like delete and save on pack and delete on item.

EngrAJ8888 commented 1 day ago

Hi @Isthisanmol , if you are referring to the cloned pack, yes that is correct. Users should have the ability to modify their cloned pack, with options to edit and delete.