Code quality fix - Public constants should be declared "static final" rather than merely "final".

andrew-hoffman / halfnes

An accurate NES/Famicom emulator

GNU General Public License v3.0

163 stars 65 forks source link

Code quality fix - Public constants should be declared "static final" rather than merely "final". #36

Closed faisal-hameed closed 8 years ago

faisal-hameed commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S1170 - Public constants should be declared "static final" rather than merely "final". You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1170

Please let me know if you have any questions.

Faisal Hameed

andrew-hoffman commented 8 years ago

merged manually (conflicted with another fix)

andrew-hoffman commented 8 years ago

Now I'm realizing that I shouldn't have pulled this one at all, it's the wrong fix entirely for a lot of these private fields. Going to have to back this out.