andrew-schofield / keepass2-haveibeenpwned

Simple Have I Been Pwned checker for KeePass
MIT License
425 stars 25 forks source link

Can't identify the specific breach #12

Closed jeff9315 closed 7 years ago

jeff9315 commented 7 years ago

The last breach in my list of breached entries is one for carnival.com. However, using the haveIBeenPwned website, I can't find an entry for carnival, nor one for the userid in my KeePass entry, nor one for any emails in that KeePass entry. It would be helpful if the breach list contained a column for the breach name as reported by HaveIBeenPwned.

Thanks ... Jeff

andrew-schofield commented 7 years ago

That's strange.

I can add some extra detail to the breach list which should hopefully clarify why this entry was detected.

jeff9315 commented 7 years ago

That would be GREAT!!

andrew-schofield commented 7 years ago

You should see the breach name in the output window if you update to v0.2.6. I'm working on getting a little more information about the breach into a tooltip when you hover over the entry in the list.

jeff9315 commented 7 years ago

Great. Thanks!!

On Tue, Apr 4, 2017, 4:30 AM Andrew Schofield notifications@github.com wrote:

You should see the breach name in the output window if you update to v0.2.6. I'm working on getting a little more information about the breach into a tooltip when you hover over the entry in the list.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/andrew-schofield/keepass2-haveibeenpwned/issues/12#issuecomment-291430572, or mute the thread https://github.com/notifications/unsubscribe-auth/ATTwX9wk-x5A4qMkdDblAMi-v1tovLfbks5rsf-2gaJpZM4Msz-k .

jeff9315 commented 7 years ago

OK ... I have an entry for Carnival Cruise Lines (https://www.carnival.com). The breach is for "nival". So, it looks like you might have a regex slightly wrong. Having the Breach name really helps a lot.

Thansk ... Jeff

andrew-schofield commented 7 years ago

That's really helpful. I'll take a look at the url checking logic and should be able to get this fixed.

andrew-schofield commented 7 years ago

OK, I've fixed the url checking code in this commit 3eff8d904340dbb4fe4ab7d74fc695944d236e4e It will be included in the next release.