search

andrew-schofield / keepass2-haveibeenpwned

Simple Have I Been Pwned checker for KeePass
MIT License
425 stars 26 forks source link

Why entries with referencing fields are ignored? #70

Open cristianst85 opened 5 years ago

cristianst85 commented 5 years ago

Hi,

Is there a specific reason why entries with referencing fields are ignored?

https://github.com/andrew-schofield/keepass2-haveibeenpwned/blob/56fab5bc88b7a623e8ae5f54e68a15bcc4b15130/HaveIBeenPwned/BreachCheckers/HaveIBeenPwnedPassword/HaveIBeenPwnedPasswordChecker.cs#L76

https://github.com/andrew-schofield/keepass2-haveibeenpwned/blob/56fab5bc88b7a623e8ae5f54e68a15bcc4b15130/HaveIBeenPwned/BreachCheckers/HaveIBeenPwnedUsername/HaveIBeenPwnedUsernameChecker.cs#L70

Imho I think at least there should be another checkbox in the dialog window where you could choose whether to resolve them or not.

Also, to improve usability, entries with referencing fields may not be counted/shown in Breached Entries window (or show them, but add extra column, e.g. Has Referencing Field).

Let me know what you think about this and I'll happily submit a PR.

Regards, Cristian

andrew-schofield commented 5 years ago

If you want to go ahead and create a PR then please do.