andrew-schofield / keepass2-haveibeenpwned

Simple Have I Been Pwned checker for KeePass
MIT License
425 stars 25 forks source link

Not working on Linux/Mono #8

Closed Generator closed 7 years ago

Generator commented 7 years ago

On linux with mono only minimizes the windows.

Envoriment: Archlinux keepass - 2.35 mono - 4.8.0.495

andrew-schofield commented 7 years ago

I'm not sure I understand. Are you saying that when you click on the menu item to run the HIBP check it minimizes KeePass and doesn't do anything else?

Generator commented 7 years ago

Yes, nothing happens, the plugins starts checking entries, when finish only minimizes the main window.

With the mono upgrade (4.8.0.495) HIBP kinda works! But sets almost all entries as expired, even entries not related to any site, like entries with only information or local accounts.

Cloudbleed doesn't work either, only minimizes the main window after checking entries, with no entries marked as expired.

andrew-schofield commented 7 years ago

I see the minimising bug on Windows as well. I think on mono the messagebox isn't appearing when it detects a breach, so it looks like nothing is happening.

I'll add a separate issue for creating a results dialog which should hopefully resolve that.

As for expiring entries with no URLs etc, that is odd as these should be ignored. I'll dig a little deeper into that one.

andrew-schofield commented 7 years ago

Try 0.2.1 to see if this improves the minimise behaviour. The problem may be that if you click on other windows while the progress dialog is shown, KeePass waits until it is finished before relinquishing focus.

Generator commented 7 years ago

I've tried not clicking anywhere, main window open.

I'll try that version as soon as possible and maybe I'll create an Archlinux package if there's no major issues.

Generator commented 7 years ago

HIBP now works properly also the new download windows shows the download progress.
Cloudbleed not even downloads data (sorted_unique_cf.txt). I see no traffic when i use "Cloudbleed Checker" Cloudbleed starts downloading but stops after a while

andrew-schofield commented 7 years ago

The timeout on the httpclient may be too low to download the cloudbleed data file. I'll increase the timeout which should fix the problem.

andrew-schofield commented 7 years ago

I've increased the timeout in 0.2.2.1 to 30 minutes (from 10).

Generator commented 7 years ago

Cloudbleed downloads 71MB (from 151.101.192.133) but the "Downloading Cloudbleed datafile" remains after download with no progress. And no entries are checked. captura de ecra_2017-03-10_23-42-50

captura de ecra_2017-03-10_23-40-34

andrew-schofield commented 7 years ago

The lack of progress relates to #3, however it shouldn't just hang at that point. Has it actually downloaded the file anywhere? Does %PROGRAMDATA% map to a sensible location on Linux when using mono?

Generator commented 7 years ago

Honestly i don't know, according to this page System.Environment.SpecialFolder.CommonApplicationData points to /usr/share
Can't be write by user, keepass stores his cache in $HOME/.local/share/KeePass/ (System.Environment.SpecialFolder.LocalApplicationData)

I've created a log see if it helps keepass.log.gz

andrew-schofield commented 7 years ago

Try 0.2.4.1. I've changed the download location for mono to LocalApplicationData, so this should get past the hanging issue.

Generator commented 7 years ago

Now its working, both checkers working with "Breached Entries" window.

PS: plugin now available on AUR

andrew-schofield commented 7 years ago

Great. I'll close this issue then.