search

andrew-schofield / keepass2-haveibeenpwned

Simple Have I Been Pwned checker for KeePass
MIT License
423 stars 24 forks source link

System.ArgumentNullException: Value cannot be null #86

Closed thomasmstein closed 4 years ago

thomasmstein commented 4 years ago

Hi Andrew, Using version 1.3.4 (KP 2.43) I get this 'System.ArgumentNullException: Value cannot be null' error.

I have checked the following options and combinations:

--------------------------------------------------------------------------------
Check ... 'site/service'    
UNTICK  Only checks entries that have not been changed since the breach -> OK
TICK    "                               -> OK
--------------------------------------------------------------------------------
Check ...'username'     
UNTICK  Only checks entries that have not been changed since the breach -> ERROR
TICK    "                               -> OK
--------------------------------------------------------------------------------
Check ...'password'                         -> OK
--------------------------------------------------------------------------------
Check ...'all'          

UNTICK  Only checks entries that have not been changed since the breach -> ERROR            
TICK    All supported breaches                      -> ERROR

TICK    Only checks entries that have not been changed since the breach -> OK
TICK    All supported breaches                      -> OK
---------------------------------------------------------------------------------

Exception Text: ** Exception Text ** System.ArgumentNullException: Value cannot be null. Parameter name: value at System.String.Join(String separator, String[] value) at HaveIBeenPwned.UI.BreachedEntriesDialog.AddBreaches(IList`1 breaches) at HaveIBeenPwned.HaveIBeenPwnedExt.d__39.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at HaveIBeenPwned.HaveIBeenPwnedExt.d__2e.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()

hibp_checker_error_02

Thanks Thomas

andrew-schofield commented 4 years ago

Confirmed

andrew-schofield commented 4 years ago

OK, I've worked out what the issue is, it should be fixed soon. The plugin wasn't asking for the full breach model anymore, which meant the results dialog wasn't able to fill in most of the fields, and crashed because the breach class list was empty.

andrew-schofield commented 4 years ago

Fixed in v1.3.5