andrew / node-xbox-controller

:video_game: [UNMAINTAINED] Interface for Xbox 360 game controller into Node.js
http://libraries.io/npm/xbox-controller
MIT License
270 stars 49 forks source link

Style hard to follow #9

Closed rwaldron closed 10 years ago

rwaldron commented 10 years ago

This is a trivial issue, but should be addressed... The current code style is inconsistent, so I don't know what to follow for the sake of contribution.

I'd like to run it through jsbeautifer and submit a PR :)

andrew commented 10 years ago

Sure, I've just not cleaned up after merging some pulls.

divanvisagie commented 10 years ago

maybe add grunt too?

rwaldron commented 10 years ago

@divanvisagie I was so tempted, but thought I'd start small and see if @andrew was interested in the little cleanup first :)

rwaldron commented 10 years ago

ALSO! This landed https://github.com/andrew/node-xbox-controller/commit/3d46a6fbf37654ee7b7075e078762b644daf250d

andrew commented 10 years ago

Grunt? What benefits would that bring?

rwaldron commented 10 years ago

@andrew Johnny-Five uses grunt to automate jshint, nodeunit, jsbeautifier and docs generation tasks

andrew commented 10 years ago

It doesn't feel like we need that level yet, it's only a small project.

We can add it in if we're feeling some pain.

rwaldron commented 10 years ago

I use it for all the things ;)

divanvisagie commented 10 years ago

Personally it makes me comfortable running grunt before submitting a PR because of jshint, nodeunit, jsbeautifier etc