andrew0030 / Table-Top-Craft

Minecraft mod that allows players to play board games together.
GNU Lesser General Public License v3.0
6 stars 2 forks source link

[BUG] Occasional Random Crash #18

Open DaRealSparky opened 1 year ago

DaRealSparky commented 1 year ago

Describe the bug Occasionally crashes on startup. Not every time but enough to be annoying. Mod works fine when it doesn't crash.

To Reproduce Steps to reproduce the behavior:

  1. Install mod on Minecraft 1.18.2 with Forge 40.2.1
  2. Start game
  3. Repeat step 2 until a crash
  4. See error

Expected behavior Game starts with no crashes

Crash log crash-2023-02-16_22.55.28-fml.txt

Versions Forge 1.18.2

andrew0030 commented 1 year ago

That's a pretty vague crash report hmm.

Does this happen without the other mods?

If it doesn't, I would recommend you add a handful of mods at a time until it happens again, narrow it down until a conflict is found. Not much else I can do here. Unfortunately this is very hard to deal with because the error is vague. Looks like something is happening, and that something causes some of my RenderType related code to brick. At least that's my best guess.

DaRealSparky commented 1 year ago

I did try several mod combos, with no crashes.

The issue is that the crash is unpredictable. It will just happen at random when I start the game. Reload the game and it works fine as if it has never crashed. I have no easy method that could tell me what mod could be causing it.

The attached crash report is I've got.

DaRealSparky commented 1 year ago

Ok. So I think I have an idea of what is causing the crash...

Lighting optimization mods.

When the crash started popping up, I had installed a mod called Radon, a port of Phosphor from Fabric to Forge. I later learned that the Distant Horizons mod (a Level-Of-Detail mod for bigger render distances) has compatibility issues with Phosphor (and presumably Radon) and recommends using a mod called Starlight.

Starlight is also a lighting optimization mod and is available on Forge and Fabric. Since installing it and removing Radon, the game has been crashing more on startup, taking 2-4 relaunches at least in order to get the game running.

However, I do believe that Distant Horizons may also be causing some issues with the crash. What they are and whether or not this is true, I am am not yet certain. I will be testing a bit later so hopefully I can get some sort of answer as to what is happening.

GiantLuigi4 commented 1 year ago

Crash log?