search

andrewMacmurray / elm-simple-animation

stateless animation utils for Elm
https://package.elm-lang.org/packages/andrewMacmurray/elm-simple-animation/latest/
MIT License
50 stars 3 forks source link

Added an example how to animate a Html.Styled node from elm-css #22

Closed rolojf closed 3 years ago

rolojf commented 3 years ago

I couldn't figure out a way to make a useful helper function to go into the Animated module as you suggested. Sorry.

I thing the Animated.custom helper function already defined by you, is enough already.

My very small contrib. is just to give an example about how to use this package with elm-css .

Regards,

andrewMacmurray commented 3 years ago

@rolojf thanks for your input!

I've left a comment about adding it as a helper to the library, let me know if that makes sense or not. I think it would be nice for others to be able to re-use what you've done more easily.

Just one other thing, could you remove the committed changes to package-lock.json? The node dependencies haven't changed in this MR

andrewMacmurray commented 3 years ago

If it's too much work though I'm happy to make the changes myself, just let me know 👍

rolojf commented 3 years ago

Andrew, please make the changes yourself. Thanks for the chance to contribute just a little. But I've been very busy and for the following weeks will be the same.

Regards,

andrewMacmurray commented 3 years ago

No worries, I’ll make some changes when I get a moment - mind if I ask for your review when it’s ready? (and obviously only if you have time)