Closed renanpvaz closed 3 years ago
@renanpvaz wow thank you so much for this! I had a very quick scan through just now and it looks pretty good, very happy for you to continue.
I think I managed to address everything we discussed but one thing came up, I'm not sure what do to about the "extended eases". Should we bring them over to the transition module or perhaps create a separate public module exposing them as Ease
values instead of Option
?
That's awesome, thanks @renanpvaz! I wouldn't worry about the extended eases in this PR, I'll add an issue and probably have a crack at it in a few days unless you wanna have a go?
You may be aware of this already but I noticed that Simple.Transition
isn't exposed in elm.json
as a public module, there's a fairly decent feedback loop with previewing elm docs locally if you run npm run docs
@renanpvaz thanks for all your work on this 👍 gonna merge this PR in and prepare a release over the weekend (I've got a couple of other random things I wanted to add) - will drop you a message when It's on the package registry
Hi, first thanks for creating the package it'll come in handy for my team! I put together this simple solution for https://github.com/andrewMacmurray/elm-simple-animation/issues/4.
I created it as a draft because I wanted to hear your thoughts before adding documentation moving things around.