search

andrewabest / Conventional

A suite of convention specifications for enforcing type and style conventions in your codebase
Microsoft Public License
97 stars 29 forks source link

Removing .NET 4.0 Support #34

Closed andrewabest closed 7 years ago

andrewabest commented 8 years ago

I'm looking to introduce .NET core support.

In doing so, to avoid the big headache of multi-targeted code, I'd like to move away from .NET 4.0, and only support .NET 4.5+.

This will also clean up Conventional's codebase quite a bit, and make contributing to it easier, as I could merge the .Net 4.5 projects back into the core projects, and not need to link files all over the place.

Throwing this out to see if anyone has any objections to this?

This would bump Conventional into 2.x. Anyone still requiring .NET 4.0 support could still use 1.x.

KodrAus commented 8 years ago

Seems like a good move to me, support for .NET 4 in the form of old releases should do the trick. Are you anticipating any major issues that might need to be backported or something?

michaelnoonan commented 8 years ago

I think it's a good idea. Every library that's ported to .NET Core is adding momentum in a positive direction (my opinion). Also I feel that because this is a test library, and you're bumping major version, there's less risk of pushing someone into an awkward situation.

Rophuine commented 8 years ago

I think the hardest part of getting my PR to Conventional ready was working out what was going on with the .csproj files and setting up all the links properly. It would definitely be nice to clean that up.

nootn commented 8 years ago

Onwards and upwards! I think if you leave a Nuget version around that is .NET 4.0 compatible no one can really complain (I.e. your 1.X version), and any new features only end up in the new one.

todthomson commented 8 years ago

:shipit:

andrewabest commented 8 years ago

@KodrAus no big issues backporting that I could see, just didn't want to tick anyone off by doing it 'out of the blue'.

Looks like an overwhelming :+1: - so this shall be happening soon(ish)!

andrewabest commented 8 years ago

Will leave this open for a while longer to see if anyone else has a contrary opinion.

andrewabest commented 7 years ago

Half a year later... a status update!

It has been quite painful attempting to convert to netstandard - in particular the Reflection libraries only seem to be advanced enough in netstandard 1.5, and I suspect most people avoid 1.5 and 1.6 as odd anachronisms, and will be holding out for netstandard 2.

Current thinking is I'll await netstandard 2 dropping in Q3 2017, which will also give Cecil time to reach 1.0 with core support.

Closing this off for the moment, will reopen an issue with .NET Core support detailing plans separately.