search

andrewalker / p5-business-cpi

Common Payment Interface
6 stars 2 forks source link

Replace EmptyLogger with SimpleLogger for #28 #33

Open openstrike opened 9 years ago

openstrike commented 9 years ago

The new class Business::CPI::Util::SimpleLogger replaces the old Business::CPI::Util::EmptyLogger and includes some trivial methods for logging which act as a fallback in the absence of a more fully-featured user-provided logger such as Log::Log4Perl. The only significant difference is that SimpleLogger has a fatal() method which actually dies. If this is retained it would probably be advisable to have an explicit die immediately after calling fatal() in case it is over-ridden by a non-terminating method. eg:

die $log->fatal('Too many jabberwocks!');

There are some additional tests for these new logging methods as well.

openstrike commented 7 years ago

Are there any further changes you require to this PR prior to merging, Andre? Any feedback which you could provide would be most welcome.