search

andrewbackes / chess

Multipurpose chess package for Go/Golang.
21 stars 5 forks source link

Wrong module name #22

Open jezek opened 6 days ago

jezek commented 6 days ago

This one is serious. I somehow messed up and now your go.mod file contains module github.com/jezek/chess instead of module github.com/andrewbackes/chess.

Also the line github.com/andrewbackes/chess v0.0.0-20171122002438-368c396b5300 should be not in require.

jezek commented 6 days ago

@andrewbackes I'm terribly sorry for my mistake. I made the mistake in PR #18 , I really don't know how I missed this. I hope you can forgive me.

How to handle the PR #23 ?

  1. Revert changes until #18, amend the PR#23, merge #19 and #20 again. Repair tags. Pros: History will be like it never happened. Cons: Other projects using this package could have trouble. More work resetting, amending and merging.

  2. Merge the PR #23, move tag v1.1.0 to last commit. Pros: No reverting & breaking history. Easy. Cons: Maybe some other projects using tag v1.1.0 could have trouble. Messing with tags.

  3. Merge the PR #23, add tag v1.1.1 to last commit. Pros: No reverting & breaking history. Easiest and "by the book". Cons: Tag v1.1.0 will be faulty forever.

I hope this helps to repair my mistake. Again, sorry.