search

andrewbanchich / forty-jekyll-theme

A Jekyll version of the "Forty" theme by HTML5 UP.
https://andrewbanchich.github.io/forty-jekyll-theme/
Other
1.06k stars 2.17k forks source link

After click 'Go Back' animation class 'is-loading' does not remove from body #144

Closed RaphaelVRossi closed 3 years ago

RaphaelVRossi commented 3 years ago

After click on Go back from browser, the class 'is-loading' was not removed from body.

Peek 2021-09-29 23-55

So, I found where is removed class 'is-loading' and changed this part:

$window.on('load pageshow', function() {
  window.setTimeout(function() {
      $body.removeClass('is-loading');
  }, 100);
});

to this:

window.setTimeout(function() {
  $body.removeClass('is-loading');
}, 200);

Because it's always adding 'is-loading' but not always removing.

Locally is working, after this change, but I don't if this change can break something, I will test more!

:smile:

RaphaelVRossi commented 3 years ago

Pull request created.

https://github.com/andrewbanchich/forty-jekyll-theme/pull/145