Invalid type of oneOf[].maxItems and oneOf[].minItems

andrewbober / xsd2jsonschema

A pure JavaScript library for translating complex XML Schemas into JSON Schemas.

https://www.xsd2jsonschema.org

Apache License 2.0

48 stars 25 forks source link

Invalid type of oneOf[].maxItems and oneOf[].minItems #15

Closed djusv closed 4 years ago

djusv commented 5 years ago

Hello, First of all thanks for creating this module so it has worked pretty well in my use case. But I did find a mismatch with the json schema specification.

maxItems section.6.4.3 a non negative integer type is expected
minItems section.6.4.4 a non negative integer type is expected

But currently the output is a string, looking at the code I think the values of XsdAttributes.MIN_OCCURS and XsdAttributes.MAX_OCCURS should be retrieved as a number in the converterDraft04.js

andrewbober commented 5 years ago

Acknowledged. I'll update the test case and get it fixed.

Thanks for the feedback!

andrewbober commented 4 years ago

This is resolved in version 0.3.5