search

andrewchambers / bupstash

Easy and efficient encrypted backups.
https://bupstash.io
MIT License
897 stars 31 forks source link

Paths broken when adding multiple subdirs of / #359

Open tlotze opened 2 years ago

tlotze commented 2 years ago

When I put multiple directories with the same call, they will be stored as subdirectories of the common parent. However, when I do this with different subdirectories of the filesystem root, such as # bupstash put /etc /home, the paths will be broken:

# bupstash list-contents
drwxr-xr-x -         2022/11/07 11:05:36 .
drwxr-xr-x -         2022/11/14 19:25:52 tc
drwxr-xr-x -         2022/02/08 09:41:19 ome
...

and bupstash get --pick will also refer to those mangled paths.

andrewchambers commented 2 years ago

Thanks for the report - it seems like this slipped through because the test suite can't test the root directory so easily.

andrewchambers commented 2 years ago

This has been fixed in master and will be in the next bug fix release.

klemensn commented 1 year ago

This has been fixed in master and will be in the next bug fix release.

This happens when testing #363 on top of 0.12.0, which is what I did through the official OpenBSD port/package, where tests failed unexpectedly.

This PR lacked a reference to the actual fix, so here it is: a73fd83dc9556d1172f73ead2258fb127e36bb56.

andrewchambers commented 1 year ago

I will try to do a release in the next week or so we can get this fix out.