search

andrewchambers / hpkgs

A package repository for hermes
45 stars 3 forks source link

Add node #114

Closed sogaiu closed 4 years ago

roobie commented 4 years ago

Other than there's no :file-name, it looks good to me.

sogaiu commented 4 years ago

Thanks for taking a look :)

In this case, I think the :url portion has an appropriate last component, so I don't think we need the :file-name. I suppose if we don't want the v in the filename, we could use :file-name...

roobie commented 4 years ago

I think you are correct. I was too nit-picky :)