andrewchambers / hpkgs

A package repository for hermes
45 stars 3 forks source link

Consider `link-/usr/bin/env` #75

Open sogaiu opened 4 years ago

sogaiu commented 4 years ago

Although it wouldn't eliminate all shebang patching, a link-/usr/bin/env would make some of the builds cleaner and reduce some shebang patching.

What are some downsides?

andrewchambers commented 4 years ago

Hmm, not too many, big core can slow down builds maybe. I wonder if there is a practical upper bound on the amount of setup some packages will require users to do :P. I guess if its grows to big, you must bundle more of the setup into combined functions.

sogaiu commented 4 years ago

On a somewhat related note, I didn't notice until today that there appears to be a /usr/bin directory in the build environment.

Is that something I can rely on?

andrewchambers commented 4 years ago

it is a symlink to /bin, I think you can rely on it.

sogaiu commented 4 years ago

Thanks.