search

andrewchilds / overcast

Orchestrate VMs from your terminal
MIT License
478 stars 36 forks source link

DigitalOcean API v2 support #42

Closed andrewchilds closed 8 years ago

andrewchilds commented 8 years ago

Upgrades Overcast to use the DigitalOcean API v2.

Requires a DIGITALOCEAN_API_TOKEN variable to be set:

$ overcast var set DIGITALOCEAN_API_TOKEN abc123
garnold commented 8 years ago

Hey @andrewchilds, something I've been meaning to ask you is why include ./node_modules in the repo instead of just doing an npm install on checkout?

andrewchilds commented 8 years ago

Hey @garnold - bundling node_modules is the safest and easiest way to lock down dependencies and sub-dependencies. The other option is to use npm shrinkwrap - I'm sure that's the npm-approved approach, but I haven't looked into it yet. Otherwise even if you freeze your dependency versions, some dependency will not have frozen sub-dependencies (or sub-sub-dependencies), and eventually something in there will break due to some incompatibility.

garnold commented 8 years ago

Thanks @andrewchilds, makes sense. And I just saw your pull for shrinkwrap.

garnold commented 8 years ago

Thanks @andrewchilds, makes sense. And I just saw your pull for shrinkwrap.

andrewchilds commented 8 years ago

Yeah after I said that, I messed up the package.json in the 1.0 release so it was a good opportunity to give shrinkwrap a try :sweat_smile: