search

andrewchilds / overcast

Orchestrate VMs from your terminal
MIT License
479 stars 36 forks source link

aws sdk upgrade to current (resolves #46) #56

Closed zbigg closed 7 years ago

zbigg commented 7 years ago

This PR upgrades aws SDK to current version. It is was needed to fix aws create to work with eu-central-1 region.

Automatic tests are passing. Tested manually on OSX with us-east-1 and eu-central-1 regions.

andrewchilds commented 7 years ago

Thanks @zbigg! Any context for the changes in modules/providers/aws.js?

zbigg commented 7 years ago

Any context for the changes in modules/providers/aws.js?

Actually i just wanted to try overcast on AWS and it didn't worked for me in my region (eu-central-1) so i searched trough bugs, found something possibly related (#46) and without any special analysis spotted that aws-sdk used was very old and gave upgrade a try.

Unfortunately i didn't do any thorough analysis of API changes ... just few try & fix loops just to make it work.

andrewchilds commented 7 years ago

There is some additional work I need to do to get this ready for release, but I'll merge this and take it from here. Thanks!