search

andrewcooke / ParserCombinator.jl

A parser combinator library for Julia
Other
107 stars 20 forks source link

Wrong Floating number regex #31

Closed guyvdbroeck closed 10 months ago

guyvdbroeck commented 5 years ago

The current implementation

PFloat64() = Parse(p"-?(\d*\.?\d+|\d+\.\d*)([eE]\d+)?", Float64)

is missing the optional sign for the exponent: "-?(\d*\.?\d+|\d+\.\d*)([eE]-?\d+)?" An implementation of PFloat16 is also missing.

richardreeve commented 11 months ago

@oxinabox - could you add me as a collaborator on this repo so I can add a PR to fix this?

oxinabox commented 11 months ago

no, but you are welcome to make a pull request.

richardreeve commented 10 months ago

I can't make a branch in the repo to make a PR because I don't have permission. Do you really want me to fork it and make a PR from my own repo? I'm not asking for permissions to actually merge anything.

oxinabox commented 10 months ago

Do you really want me to fork it and make a PR from my own repo?

Yes. That is exactly what i want.

richardreeve commented 10 months ago

Okay, you can close this now btw.