search

andrewd18 / df-lnp-installer

An installation script for the Dwarf Fortress Lazy Newb Pack, for Linux.
Other
93 stars 35 forks source link

False negative for missing dep in fedora 17 #46

Closed pgelinas closed 10 years ago

pgelinas commented 10 years ago

When I run the installation script, it complains about missing Qt lib: libQtCore libQtGui libQtNetwork libQtScript. However, these are available it's just that the check doesn't find them because of the regex. Here's my ldconfig output:

$ /sbin/ldconfig -p | grep -P '^\tlibQt(Co|Net|Sc|Gui)'
    libQtScriptTools.so.4 (libc6,x86-64) => /lib64/libQtScriptTools.so.4
    libQtScriptTools.so.4 (libc6) => /lib/libQtScriptTools.so.4
    libQtScript.so.4 (libc6,x86-64) => /lib64/libQtScript.so.4
    libQtScript.so.4 (libc6) => /lib/libQtScript.so.4
    libQtNetwork.so.4 (libc6,x86-64) => /lib64/libQtNetwork.so.4
    libQtNetwork.so.4 (libc6) => /lib/libQtNetwork.so.4
    libQtGui.so.4 (libc6,x86-64) => /lib64/libQtGui.so.4
    libQtGui.so.4 (libc6) => /lib/libQtGui.so.4
    libQtCore.so.4 (libc6,x86-64) => /lib64/libQtCore.so.4
    libQtCore.so.4 (libc6) => /lib/libQtCore.so.4
    libQtContacts.so.1 (libc6,x86-64) => /lib64/libQtContacts.so.1
    libQtContacts.so.1 (libc6) => /lib/libQtContacts.so.1
    libQtConnectivity.so.1 (libc6,x86-64) => /lib64/libQtConnectivity.so.1
    libQtConnectivity.so.1 (libc6) => /lib/libQtConnectivity.so.1

The regex in the script expect a whitespace at the end of the dependencies (^\tlibQtNetwork.so\s) but it isn't the case. Either remove the whitespace from the regex or make it optionnal would fix the problem.