search

andrewdavey / immutable-devtools

Chrome Dev Tools custom formatter for Immutable-js values
BSD 3-Clause "New" or "Revised" License
661 stars 29 forks source link

Failing on Chrome Canary builds #19

Closed matthewleon closed 8 years ago

matthewleon commented 8 years ago

On Chrome build 51.0.2689.0 (actually, for versions stretching back for the preceding week or so), attempts to click on a logged Immutable.js object now result in:

VM562:9 Custom Formatter Failed: ReferenceError: bindRemoteObject is not defined

I suspect that there's some kind of permanent change to the Custom Formatter API. A few Google searches have revealed precious little information, sadly.

awalkerca commented 8 years ago

Version 51.0.2687.0 dev (64-bit)

I'm seeing the same issue on the dev build of stable Chrome.

darwin commented 8 years ago

Just FYI. We have the same problem here: https://github.com/binaryage/cljs-devtools/issues/14

langpavel commented 8 years ago

Hi @darwin. Do you think we should delegate this to Chromium? I'm sure that bindRemoteObject is not used in this project.

darwin commented 8 years ago

The problem seems to be this call: https://github.com/binaryage/dirac/blob/devtools/front_end/components/CustomPreviewSection.js#L213

It has been there for a long time and that function is not defined anywhere in DevTools code, so I assume it was provided as part of WebKit environment. So I assume someone removed that function or broke it in some way in recent builds. I don't really have time and expertise to go through WebKit/Chromium sources to find what changed at this point.

I believe this will be solved soon when they notice this function is missing. It was probably just renamed or moved elsewhere.

mattzeunert commented 8 years ago

It's working for me with the current Chrome Canary.

darwin commented 8 years ago

@mattzeunert Please paste here your Chrome version / OS.

It is still broken in Mac Chrome 51.0.2691.0 canary (64-bit). The bug is reproducible when you try to expand a console log generated via custom formatters (by clicking on its disclosure triangle).

mattzeunert commented 8 years ago

@darwin Ah, got it.

mattzeunert commented 8 years ago

This is the issue in the Chromium bug tracker: https://bugs.chromium.org/p/chromium/issues/detail?id=595206

darwin commented 8 years ago

I have just raised the issue upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=599884

langpavel commented 8 years ago

Thanks @darwin, I starred the issue.

darwin commented 8 years ago

Fixed in 51.0.2702.0 canary (64-bit)

langpavel commented 8 years ago

Great! :-)