andrewdavey / immutable-devtools

Chrome Dev Tools custom formatter for Immutable-js values
BSD 3-Clause "New" or "Revised" License
661 stars 29 forks source link

Typo in renderIterableBody? #36

Open benny-medflyt opened 5 years ago

benny-medflyt commented 5 years ago

Hi, I was reading through the code of this library, and read the renderIterableBody function. Here is the source for it:

  const renderIterableBody = (collection, mapper, options = {}) => {
    if (options.sorted) {
      collection = collection.sortBy((value, key) => key);
    }
    const children = collection
      .map(mapper)
      .toList();

    const jsList = []
    // Can't just call toJS because that will also call toJS on children inside the list
    children.forEach(child => jsList.push(child))

    return [ 'ol', listStyle, ...children ];
  }

It seems that the author carefully crafted the jsList list, but then forgot to use it, and mistakenly used children instead.