Open benny-medflyt opened 5 years ago
Hi, I was reading through the code of this library, and read the renderIterableBody function. Here is the source for it:
renderIterableBody
const renderIterableBody = (collection, mapper, options = {}) => { if (options.sorted) { collection = collection.sortBy((value, key) => key); } const children = collection .map(mapper) .toList(); const jsList = [] // Can't just call toJS because that will also call toJS on children inside the list children.forEach(child => jsList.push(child)) return [ 'ol', listStyle, ...children ]; }
It seems that the author carefully crafted the jsList list, but then forgot to use it, and mistakenly used children instead.
jsList
children
Hi, I was reading through the code of this library, and read the
renderIterableBody
function. Here is the source for it:It seems that the author carefully crafted the
jsList
list, but then forgot to use it, and mistakenly usedchildren
instead.