search

andrewdavey / postal

Email sending for asp.net mvc using the view engine system to render emails.
http://aboutcode.net/postal
MIT License
536 stars 169 forks source link

Update to .Net 5 #181

Open johanjvr opened 3 years ago

johanjvr commented 3 years ago

Hi I've updated this to use .Net 5.0

rickdgray commented 1 year ago

Hey @hermanho, How keen are you on merging your repo into this one? You've done a huge amount of work over there that I want to be a part of this project! But this PR was started by @johanjvr, so I wanted to make sure you are actually OK with that and wanted your work to be merged in. I would anticipate we would release future .NET Core versions to nuget under the original "Postal" name instead of the "PostalAspNetCore" package name you've been using. I am also looking to deprecate any .NET Framework support for the foreseeable future. Also, I see you're migrating your repo to use actions (great!) and have pushed out some preview builds. Is this currently a work in progress? How ready are you to merge?

hermanho commented 1 year ago

Hi @rickdgray, I am happy to let you merge it into this repo. I have not done a well test in .NET 6 so it is hard to comment on the readiness. For the GitHub Actions, it is just my experience so I think Postal repo has different way to do CICD.

rickdgray commented 1 year ago

I've gone through the repo and test cases and it looks pristine! I now want to double check the CICD as you mentioned.