andrewdavidmackenzie / pigg

Raspberry Pi GPIO GUI
Apache License 2.0
157 stars 8 forks source link

Add Hyperlink Support to the Version Modal #427

Closed sundaram123krishnan closed 1 week ago

sundaram123krishnan commented 2 weeks ago

Closes #426

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 22.72727% with 34 lines in your changes missing coverage. Please review.

Project coverage is 28%. Comparing base (da842a2) to head (e5e25d9). Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/views/modal_handler.rs 21% 34 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #427 +/- ## ===================================== - Coverage 28% 28% -0% ===================================== Files 40 40 Lines 4821 4853 +32 ===================================== + Hits 1349 1355 +6 - Misses 3472 3498 +26 ``` | [Flag](https://app.codecov.io/gh/andrewdavidmackenzie/pigg/pull/427/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Mackenzie) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/andrewdavidmackenzie/pigg/pull/427/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Mackenzie) | `28% <23%> (-<1%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andrew+Mackenzie#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sundaram123krishnan commented 1 week ago

Opened issue regarding the refactor, https://github.com/andrewdavidmackenzie/pigg/issues/437, thinking to address all the above changes in that PR.