andrewdnolan / thermal-structure

Thermomechanically coupled surging experiments with Elmer/Ice
MIT License
0 stars 0 forks source link

Air temperature incorrectly initialized in restarts #11

Closed andrewdnolan closed 1 year ago

andrewdnolan commented 1 year ago

The variable name used to set the initial condition for the Surface_Enthalpy field was incorrectly spelled. No underscore included (i.e. Surface Enthalpy).

https://github.com/andrewdnolan/thermal-structure/blob/0fa70ed5d1041d26691d467032663b005d93f9b2/expr/03_PeriodicSurge/sifs/periodic_surge.sif#LL142C30-L142C30

This meant the field was never updated in time, and the value from the restart simulation was used for the entire diagnostic simulation, which in effect is a position dependent air temperature. This is only a problem as of the "new" heat pump parameterization, where the restart need to be specified in order for the fields to be updated in time.