coderschoolreview
commented
8 years ago :+1: nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. You learnt how to use AutoLayout to build adaptive UI's that work across many different screen sizes and orientations. If you haven't already, we recommend going back and running your homework again while rotating the device / simulator to ensure your AutoLayout constraints function as expected.
This was a challenging assignment, congrats on completing it successfully!
Grading Summary:
- Functionality: Good
- Code Style: Excellent
- Visual Design: Good
- Usability: Good
Overall: Good
Detailed Notes
- Nice work specifying the Auto Layout constraints. One small thing here, you may want to create multiLines label for the category and address.
- Nice work linking the filter model with the controls. See this popular form library for an alternative to implementing forms manually.
- Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.
- When no result found, you should somehow tell the user, rather then display empty table.
- You set the tint color of the search bar to be white, hence user can't see the cursor, and will not know the search bar is on focus.
- After search, the keyboard is still there. Either you dismiss it as soon as user taps
Search, or when user taps outside. - Infinite loading is interesting, when you need to research and understand the Yelp API. You should consider going back and implementing these improvements as well.
Ready for review /cc @coderschoolreview