Assignment 1

[andrewduck]

Ready for review /cc @coderschoolreview

[minhchau273]

:+1: Nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.

Grading Summary:

• Functionality: Good
• Code Style: Excellent
• Visual Design: Average
• Usability: Good

Overall: Good

Detailed Notes

• Great clean code. Good job utilizing the best parts from the style guide:
  • Ray Wenderlich Swift Style Guide
• In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response. For a more robust solution, you can also investigate using an ORM like Pistachio.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Your error message should be displayed if a network request fails and hidden again if it succeeds. For now, you only show the error label in case of getting error when requesting data. But this error is not alway the network error. It can be caused by the api. You can use Reachability in this case to detect the network error.
• Nice job implementing a UIScrollView. UIScrollView is the parent class of UITableView.
• Nice job keeping things nice and aligned on a grid. That helps the application look cleaner and make it easier for the user to find the correct information. For a lot more information, you can read Design tips for iOS9.
• There's a small issue with search bar. When I select a movie from the results, your app shows another movie details.
  
• When I tap Cancel button on the UISearchBar, your app crashes.

Homework is the core part of this class. Through the homework assignments you'll create real apps that you should be proud to show anybody. The more time you spend, the better your portfolio will be and the more you will learn. Try to spend a little more time next week!