search

andrewelick / amazon-giveaway-bot

Bot that automatically enters you in to hundreds of instant amazon giveaways
13 stars 6 forks source link

Async and other improvements #2

Closed mdobro closed 5 years ago

mdobro commented 5 years ago

Hi, I added async functionality to make things run faster as well as some other enhancements.

There are some things that are hard coded that would be nice to move out, but I wanted to send this your way now that its working.

Great program! I actually won a pair of crochet pins last night lol.

mdobro commented 5 years ago

Oh, and I added mac support (that is what my code is working on right now) you will probably need to edit some things into the code to get it running on windows.

mdobro commented 5 years ago

Another note, I haven't figured out how to kill everything smoothly yet so I've been just doing pkill python3 in a separate terminal window

mdobro commented 5 years ago

I think the next thing I'd like to add is a way to keep track of already entered contest URLs and just remove them from the list before calling them

mdobro commented 5 years ago

@andrewelick virtualenvironments help keep your global python dependency from having a bunch of stuff in it. Some stuff is good to have for every project, but sometimes you install stuff and you don't want it to effect other projects on your computer. You don't HAVE to use one, but I think they keep things clean so I try to when I do python development.

andrewelick commented 5 years ago

Hey man, love the work you are doing, but I am currently on vacation right now and you have been committing quite a bit. If you could slow down a for a while I can spend some time reviewing over them. Adding 15+ commits is a bit overwhelming, but I thank you for your help, appreciate it greatly!

mdobro commented 5 years ago

@andrewelick no worries about the review. I just wanted you to be aware of it in case you wanted to use it for black friday.

I'm just adding some time saving features that will improve how it runs like ignoring contests that you've already entered which will save a whole lot of time on requests that aren't need

mdobro commented 5 years ago

This code needs to be cleaned up anyway. I will close the PR for now and send a new one when its a bit easier to read.

AMDphreak commented 5 years ago

which virtual environment is used?