search

andrewfiorillo / sketch-palettes

A Sketch plugin for exporting and importing fill presets. It supports colors, gradients, and pattern fills.
MIT License
2.27k stars 134 forks source link

Colors are not saved between sessions #20

Closed Niknam closed 8 years ago

Niknam commented 8 years ago

When closing the Sketch document and reopening it, the color palette is reset to default and I have to reload the palette with my saved colors. I even recall the colors resetting during the same session.

andrewfiorillo commented 8 years ago

Which version of Sketch are you running?

Niknam commented 8 years ago

3.8.1, but I experienced the same issue while running 3.7.x as well.

andrewfiorillo commented 8 years ago

Did you grab the latest version of this plugin?

Niknam commented 8 years ago

I have v1.1 of this plugin. Is that the latest version?

andrewfiorillo commented 8 years ago

Yeah, it is. I can't seem to reproduce with either version of Sketch (3.7.2 and 3.8.1). To clarify, is this using Document Colors, Global Colors, or both? Also, could you send me the palette file so I can take a look? fiorilloaj@gmail.com

Niknam commented 8 years ago

I usually only change the Document Color, but once I accidentally changed the Global Colors. However, during the next session both the Global and Document Colors were reset to default. Sure, will send the palette file right away.

chrischernoff commented 8 years ago

I'm on 3.7.2 with 1.1 and am having the same issue. Here is the palette I've been using.

Documents don't retain document colors once they've been closed, and global colors are reset to my old global palette that was set by this plugin once Sketch is quit. I haven't attempted to replace my global palette in a while, so I suspect this is something with Sketch 3.7+

andrewfiorillo commented 8 years ago

Weird. I'm running the same versions (3.7.2 and 1.1) as you. I just re-downloaded my plugin from Github to make sure it is the same. Using your palette file, I'm still not able to reproduce the bug. @chrischernoff could you provide the sketch file you are working with?

chrischernoff commented 8 years ago

I think the version of the plugin I had was an older version of 1.1. When looking in Plugins → Preferences, I saw 1.1. After viewing it in Finder I saw the date modified was ~11/27/15. Having seen your latest commit on here is 1/27/16, I uninstalled and reinstalled. Sure enough, the latest download has a date modified of 1/27/16. It works as expected now, although it still says 1.1 in Preferences → Plugins, so not sure what that's about.

Edit: Went digging in my trash to find the old uninstalled version. The version number in manifest.json is identical.

"version": "1.1",

andrewfiorillo commented 8 years ago

Yeah, that's my fault. I merged a pull request from someone else when a bug popped up previously, and didn't update the version number. I appreciate you catching that!

andrewfiorillo commented 8 years ago

@Niknam if you download the plugin again (version 1.2), I think the problem should be resolved. Let me know if that doesn't do the trick!

Niknam commented 8 years ago

@chrischernoff That was very observant. Thanks for the effort! @andrewfiorillo 1.2 seems to do the trick! Thanks a lot for the quick replies! Much appreciated. :)

chrischernoff commented 8 years ago

👍