Sketch 44.1 crashes when 'Clear palette' is used and then palette toggling happens

andrewfiorillo / sketch-palettes

A Sketch plugin for exporting and importing fill presets. It supports colors, gradients, and pattern fills.

MIT License

2.27k stars 135 forks source link

Sketch 44.1 crashes when 'Clear palette' is used and then palette toggling happens #48

Closed davewallace closed 7 years ago

davewallace commented 7 years ago

Hi there,

First off, sweet plugin - thank you :)

Secondly, I crashed Sketch today by doing the following on macos Sierra (up-to-date):

Sketch is open (with 2 files open)
Checkout today's repo into ~/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Sketch Palettes
Sketch successfully loads the newly available Plugin
I exported a Global-only palette from file 1
I imported that palette into file 2, success
I realise I should've selected 'Document' and I use the 'Clear pelette' menu option
I remove the Global palette, the colour palette panel does not reflect this change
I try to toggle visibility on the colour palette panel to a closed state, and I try to re-expand it, in an attempt to see if the app's state just needs a kick
BAM!

Actually I am not certain whether it was the expand or collapse action that crashed, but it was one of them.

andrewfiorillo commented 7 years ago

I can't seem to reproduce this bug now. This was a known issue previously, until the last release of Sketch, where those actions stopped causing a crash. Are you using the latest version of Sketch?

davewallace commented 7 years ago

I wasn't updated - 44.1 was the reported version number though. It was bad update timing, I refused the updater just that same morning. I've now updated (still on 44.1 which is odd), and the issue continues - here's a screencast (excuse the chugginess, QuickTime very slow for some reason): https://drive.google.com/file/d/0B1dgdFJOLjqweTRuXzVwampDZU0/view?usp=sharing

Also, this repo was a fresh clone on the same day (last Friday) without having ever installed it before, so I wouldn't have any previous install history (I'm pretty new to Sketch).

andrewfiorillo commented 7 years ago

Ok, I was able to reproduce it. It only happens when clearing, not loading I believe. I've been trying to figure out how to update the color picker while it is open, but haven't had much luck. That being the case, a quick fix for this might be to just close the popover when the palette is cleared, preventing the actions that cause the crash, since you currently have to close and re-open the color picker to see the changes reflected anyway.

andrewfiorillo commented 7 years ago

Ok, I went ahead and implemented closing the popover when a palette is cleared or loaded. If you grab the latest release, you shouldn't be able to trigger the crash now. Going to go ahead and close this ticket.