Clean up Dockerfile - Githubissues

andrewfraley / arris_cable_modem_stats

Retrieves stats from Arris cable modems and sends to InfluxDB

53 stars 34 forks source link

Closed mbentley closed 3 years ago

mbentley commented 3 years ago

Signed-off-by: Matt Bentley mbentley@mbentley.net

mbentley commented 3 years ago

Thanks for the recent updates! I was looking through the Dockerfile and it can be optimized a bit:

Set the FROM image to by 3.8 so it just gets the latest bugfix version.
Collapse all ENV layers into a single ENV line so it will set them all in one layer; making it quicker to build and pull
Change the CMD to so that it doesn't execute a shell to run python, it will just directly call python. Without brackets, it'll call /bin/sh -c '<command>

andrewfraley commented 3 years ago

@mbentley thanks for doing this!