search

andrewfraley / arris_cable_modem_stats

Retrieves stats from Arris cable modems and sends to InfluxDB
53 stars 34 forks source link

Added T25 Support + Allow custom get_token methods to be used #44

Closed Hackerjef closed 2 years ago

Hackerjef commented 2 years ago

Hello!

In this commit you will find the following:

  1. Support for the Arris T25 (Comcast firmware)
  2. The ability for Device "Models" to have a get_token method along with the normal parse_html

Thanks

andrewfraley commented 2 years ago

Hi @Hackerjef, thank you for this! Are you able to get the unit tests working? There are some very basic instructions here, but if you need assistance please let me know. Thanks!

Hackerjef commented 2 years ago

No worries, and got the tests to work,

I noticed between sb6193 and sb8200 that the types for some of the data is mismatching, I based the t23's model off of the sb8200 data model, is that intentional?

example: sb6183 has freq as an int, while sb8200 has it as a string

andrewfraley commented 2 years ago

The sb6183 code was written by someone else, so I would say that's not intentional. Thanks for getting the tests working! I'll just confirm that the sb8200 still works on my end after your changes, then I'll merge this. Probably won't be until tomorrow morning, though. Thanks!

Hackerjef commented 2 years ago

No worries! Take your time and take care

andrewfraley commented 2 years ago

@Hackerjef Is it supposed to be T25 instead of T23? If so, maybe just a quick search and replace? :)

Hackerjef commented 2 years ago

Wow I can't believe I did that, Lack of sleep really is getting to me. Sorry!

andrewfraley commented 2 years ago

LOL no worries, I've made plenty of similar mistakes :)