search

andrewgiessel / basketballcrawler

DEFUNCT - This is a python module to scrape basketball-reference.com and convert various stats into usable data structures for analysis
123 stars 56 forks source link

First look. #1

Closed bde closed 11 years ago

bde commented 11 years ago

First look at the code. Switched from utilizing prints to using logging.

andrewgiessel commented 11 years ago

Hi! Thanks for the PR.

This looks good and I'll merge it in. Two things the logging brings to mind:

  1. The one other place where debugging could be useful is in the getSoupFromURL() function.
  2. How the suppressOutput flag is used and pushed through down to the getSoupFromURL(). it could probably be removed now, and instead use the logging level?

I don't know if you have suggestions here- I haven't used the logging module much but it obviously seems useful.

Thanks for your interest. If you have any ideas, let me know!