A few changes I had to make to get it running

andrewgiessel / basketballcrawler

DEFUNCT - This is a python module to scrape basketball-reference.com and convert various stats into usable data structures for analysis

123 stars 56 forks source link

A few changes I had to make to get it running #12

Open toddgaron opened 7 years ago

toddgaron commented 7 years ago

Hi,

When I tried to run buildPlayerDictionary, I wasn't getting player height, weight or position. The tag you've been using isn't in the Basketball Reference css anymore so I updated that. I also found that the game logs weren't being parsed correctly, it was trying to add the splits with the game logs, so I set it to only save the logs. The post-season logs were being hidden in a comment, so I wrote a little code to parse them and pull out the relevant table.

-Todd

andrewgiessel commented 6 years ago

Sorry for the inattention to this PR! I merged some other stuff, so I've you're still interested, please rebase and fix the merge conflicts.

Thanks again.