search

andrewgiessel / basketballcrawler

DEFUNCT - This is a python module to scrape basketball-reference.com and convert various stats into usable data structures for analysis
123 stars 56 forks source link

Begin scraping basic player information #6

Closed wilsonchaney closed 8 years ago

wilsonchaney commented 8 years ago

Added parsing of player positions, height, and weight.

I won't be re-running buildPlayerDictionary() just yet because I want to add a few other features in different PRs - then I'll update the stored player info.

andrewgiessel commented 8 years ago

Awesome! This looks pretty good and is quite straightforward - do you want me to merge it now, or would you like to add all your features into the same PR?

wilsonchaney commented 8 years ago

@andrewgiessel Go ahead and merge - I'll open a second, bigger PR later on.

andrewgiessel commented 8 years ago

sweet, done! thanks and keep em coming! :+1: :smile: