andrewgiessel / basketballcrawler

DEFUNCT - This is a python module to scrape basketball-reference.com and convert various stats into usable data structures for analysis
123 stars 56 forks source link

Added a class for a player, instead of using a dictionary #7

Closed wilsonchaney closed 8 years ago

wilsonchaney commented 8 years ago
wilsonchaney commented 8 years ago

@andrewgiessel Thoughts?

andrewgiessel commented 8 years ago

sorry to not respond sooner! I'll check this out this afternoon. Might you link me a ipynb that uses the new API? That'd be super helpful.

On Fri, Feb 12, 2016 at 4:25 PM wilsonchaney notifications@github.com wrote:

@andrewgiessel https://github.com/andrewgiessel Thoughts?

— Reply to this email directly or view it on GitHub https://github.com/andrewgiessel/basketballcrawler/pull/7#issuecomment-183493069 .

wilsonchaney commented 8 years ago

Here's a basic notebook I threw together.

I made sure to preserve all of the game log functionality in this notebook

andrewgiessel commented 8 years ago

Looks great! Thanks for the notebook! I'll merge this. Would you be interested in turning these notebooks into an "official" one in another PR after cleaning it up a bit?

On Wed, Feb 17, 2016 at 5:49 PM wilsonchaney notifications@github.com wrote:

Here's a basic notebook https://gist.github.com/wilsonchaney/ea564405b427942c170b I threw together.

I made sure to preserve all of the game log functionality in this notebook https://github.com/andrewgiessel/basketballcrawler/blob/master/basketball_scraper_notebook.ipynb

— Reply to this email directly or view it on GitHub https://github.com/andrewgiessel/basketballcrawler/pull/7#issuecomment-185290235 .

wilsonchaney commented 8 years ago

Yep! I'm going to be busy this coming weekend but I'll put a more comprehensive notebook together next week.