Closed wilsonchaney closed 8 years ago
@andrewgiessel Thoughts?
sorry to not respond sooner! I'll check this out this afternoon. Might you link me a ipynb that uses the new API? That'd be super helpful.
On Fri, Feb 12, 2016 at 4:25 PM wilsonchaney notifications@github.com wrote:
@andrewgiessel https://github.com/andrewgiessel Thoughts?
— Reply to this email directly or view it on GitHub https://github.com/andrewgiessel/basketballcrawler/pull/7#issuecomment-183493069 .
Here's a basic notebook I threw together.
I made sure to preserve all of the game log functionality in this notebook
Looks great! Thanks for the notebook! I'll merge this. Would you be interested in turning these notebooks into an "official" one in another PR after cleaning it up a bit?
On Wed, Feb 17, 2016 at 5:49 PM wilsonchaney notifications@github.com wrote:
Here's a basic notebook https://gist.github.com/wilsonchaney/ea564405b427942c170b I threw together.
I made sure to preserve all of the game log functionality in this notebook https://github.com/andrewgiessel/basketballcrawler/blob/master/basketball_scraper_notebook.ipynb
— Reply to this email directly or view it on GitHub https://github.com/andrewgiessel/basketballcrawler/pull/7#issuecomment-185290235 .
Yep! I'm going to be busy this coming weekend but I'll put a more comprehensive notebook together next week.
def getSoupFromURL()
players.json
to contain data from previous PR (height, weight, positions).