search

andrewgioia / mana

Magic: the Gathering mana symbol pictographic font
304 stars 32 forks source link

Undefined variable `$ms-ability-grad` in the SASS stylesheet #64

Closed mcottret closed 3 years ago

mcottret commented 3 years ago

Hi,

First of all thanks for the project, I just started using it & it looks great !

There is an error when trying to @import or @use the Mana SASS stylesheet, it seems like the ms-ability-grad variable is not defined.

SassError: Undefined variable.
  ╷
2 │     background: $ms-ability-grad;
  │                 ^^^^^^^^^^^^^^^^
  ╵

It is possible to work around this by defining the variable before importing, but adding it with a !default would fix the issue & allow to @use & override it.

$ms-ability-grad: linear-gradient(0deg, #c8913b 0%, #ecc65a 100%) !default;

Cf https://github.com/andrewgioia/mana/commit/2afc3cab1091a870e023e84b5e1389eb8504c961

Thanks a lot, cheers !

andrewgioia commented 3 years ago

Fixed in 1.13.0