andrewhathaway / Winterfell

Generate complex, validated and extendable JSON-based forms in React.
http://winterfell.andrewhathaway.net
MIT License
785 stars 116 forks source link

custom Classes per question #17

Open VinSpee opened 9 years ago

VinSpee commented 9 years ago

I'd love to be able to use custom classes on a single question. is this possible? This is how I would expect it to work:

 … }, {
    panelId : 'register-panel',
    panelHeader : 'My Awesome Form',
    panelText : 'We don\'t have a survey for you yet, how about we get you subscribed?',
    classes: {
      radioList : 'Field--paired Grid Grid--alignMiddle Grid--withGutters',
      radioListItem : 'Grid-cell u-size1of4'
    }, …
andrewhathaway commented 9 years ago

Completely possible.

I'm assuming this would override any previous question classes, not merge them?

VinSpee commented 9 years ago

That's what I had in mind

(null)

On Fri, Sep 4, 2015 at 5:27 PM, Andrew Hathaway notifications@github.com wrote:

Completely possible.

I'm assuming this would override any previous question classes, not merge them?

Reply to this email directly or view it on GitHub: https://github.com/andrewhathaway/Winterfell/issues/17#issuecomment-137857218

andrewhathaway commented 9 years ago

Perfect. Will implement.

Appreciate the feedback and glad to see some use!

VinSpee commented 9 years ago

I'm in the middle of a prototype and this lib seems to tick all of the boxes for me. I started implementing it today - I'll be sure to file for things that I find I'm missing out on. Also the surface area is pretty small, so my might see a PR or two from me next week. 

Thanks for the great library, communication, and willingness to implement! 

(null)

On Fri, Sep 4, 2015 at 6:16 PM, Andrew Hathaway notifications@github.com wrote:

Perfect. Will implement.

Appreciate the feedback and glad to see some use!

Reply to this email directly or view it on GitHub: https://github.com/andrewhathaway/Winterfell/issues/17#issuecomment-137868097

andrewhathaway commented 9 years ago

Perfect. Anything to make it better overall and become a major option for people to choose. The main aim is to make it fit anyones needs and have the flexibility to fit around their current systems etc,

You're very welcome!

ericalli commented 8 years ago

@andrewhathaway Just curious if this was ever implemented?

andrewhathaway commented 8 years ago

Hi @ericalli. Not as of yet, I was waiting for @VinSpee's PR!

I'll have to take some time to this done and fix a few more issues!