search

andrewhathaway / Winterfell

Generate complex, validated and extendable JSON-based forms in React.
http://winterfell.andrewhathaway.net
MIT License
785 stars 116 forks source link

Adding a title to a question set #33

Closed benbonnet closed 9 years ago

benbonnet commented 9 years ago

I hope this dirty schema explains the idea :

capture

As there is a title to the panel, there'd be one on the set. Or I missed the option in the docs

andrewhathaway commented 9 years ago

Hi @bbnnt.

You cannot currently add a title to a question set, but you can add one to a questionPanel and a question. If this is something you think would be worthwhile, it can be done!

benbonnet commented 9 years ago

Hi (sorry I forgot :/) ! Maybe the demo provided confused me; can you have all your panels displayed at the same time ? That'd solve it too

andrewhathaway commented 9 years ago

Panels are not supposed to be displayed all at once no, panels are like pages. Question sets however are all rendered one after another.

benbonnet commented 9 years ago

That's what I wasn't sure of; what do you think, worthwhile to add titles to questions sets ?

andrewhathaway commented 9 years ago

I imagine so If you wanting this and have a case for it.

Moving forward I can add it in sometime soon or you can PR it if you feel comfortable doing so!

benbonnet commented 9 years ago

I'll have a look at it yep

andrewhathaway commented 9 years ago

@bbnnt Fixed. Information in the README. Will be live in the next release, which I am getting round to very soon.

benbonnet commented 9 years ago

could not get enough time to go into this; but thanks a lot for this improvement !