search

andrewhathaway / Winterfell

Generate complex, validated and extendable JSON-based forms in React.
http://winterfell.andrewhathaway.net
MIT License
785 stars 116 forks source link

Submit button #39

Closed ryoia closed 9 years ago

ryoia commented 9 years ago

Hi, I got rid of all submit button related things in this schema, but there is still a submit link on the page, does Winterfell internally generate the submit for all schemas?

http://pastebin.com/20gFktDS

Thanks!

andrewhathaway commented 9 years ago

A submit/next button is always shown, is there a reason you would want to disable the submit button?

ryoia commented 9 years ago

We have our own submit button that uses react-router's Link to another page, is there a way to do such thing in Winterfell? Thanks!

andrewhathaway commented 9 years ago

Out of curiosity, why would you want to do this? How would you submit the form if you are not having a submit action?

ryoia commented 9 years ago

We currently have two schemas, one is for login, then the main one. So the button we have has a link to the main page once the login credential passed.

andrewhathaway commented 9 years ago

Right I see. This feature would need to be implemented.

ryoia commented 9 years ago

That'd be good, thanks!

andrewhathaway commented 9 years ago

@ryoia Fixed. Will be pushed in the next update. Check the README for how I've implemented this.

ryoia commented 9 years ago

I see a button disabled option, I will try to set that to true. Thanks!

andrewhathaway commented 9 years ago

You will need to download the latest version from this repo and build it or wait for the new release.

andrewhathaway commented 9 years ago

@ryoia New version published.

ryoia commented 9 years ago

This worked as well, thank you for the quick release and fix!