andrewhayden / folderslice

Automatically exported from code.google.com/p/folderslice
0 stars 0 forks source link

FolderSlice breaks on folders having a single quote in their names #15

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a folder with a single quote (') in its name
2. Attempt to run FolderSlice on this folder or any of its parents
3. Gadget will fail to display details correctly.

What is the expected output? What do you see instead?
Gadget should work properly.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by andrew.h...@gmail.com on 7 Apr 2008 at 2:57

GoogleCodeExporter commented 9 years ago
There is a bug in the code.  When passing paths from the analysis flyout to the 
main 
widget, the path has to be passed as a string that is interpreted at runtime.  
The 
call chain places the path into a string that is constructed and handed to the 
timer, and when it does so it encloses the path in single quotation marks.  A 
path 
with a single quotation mark in it will cause the Javascript interpreter to 
(correctly) terminate the string at the point it is encountered, resulting in a 
corrupt call in a timer that simply disappears into the void.

The fix for this is relatively straightforward; since paths cannot contain a 
double 
quotation mark, we will enclose paths in double quotation marks when building 
timer 
calls.  This should fix the problem.

Original comment by andrew.h...@gmail.com on 7 Apr 2008 at 3:00

GoogleCodeExporter commented 9 years ago
Fixed in 0.9.5.

Original comment by andrew.h...@gmail.com on 7 Apr 2008 at 6:35