search

andrewhead / tutorons-server

Routines for generating micro-explanations of online code as a web service.
http://www.tutorons.com
6 stars 2 forks source link

CSS selector detecting works! #31

Closed mwaliman closed 8 years ago

mwaliman commented 8 years ago

detects css selectors in code and pre blocks

andrewhead commented 8 years ago

Matthew, thanks for a great effort on the pull request! My comments are all with regards to style, but should be addressed before we integrate this into the code. Let me know if you have any questions.

andrewhead commented 8 years ago

Merge the two commits with the same name, and revert regexper-static to the earlier version of the commit.

andrewhead commented 8 years ago

Make sure to update the python requirements for the project, as tinycss is now a dependency:

pip freeze > (source directory)/launch/roles/webserver/files/tutorons-reqs.txt
andrewhead commented 8 years ago

Can you fix this bug related to the regions that the stylesheet detector finds? Currently, it is finding a "th" in the "width" parameter of a style:

tmp
andrewhead commented 8 years ago

Meanwhile, here's a good bonus: your detector apparently finds selectors in stylesheets that are embedded within HTML! Taken from jQuery API:

tmp2
andrewhead commented 8 years ago

Passed! Let's merge this.