andrewhoule / silverstripe-photogallery

Simple photo gallery with albums for Silverstripe
BSD 3-Clause "New" or "Revised" License
11 stars 13 forks source link

Silverstripe 4 migration #16

Closed ggrune closed 6 years ago

ggrune commented 6 years ago

Please take a look. I have tried to migrate the photogallery to Silverstripe 4

andrewhoule commented 6 years ago

This looks great, thanks!!! I just tried things quick... Looks like the sliderfield hasn't been upgraded to SS4 yet, so I'm getting conflicts there. I'm going to try to drop that dependency, and create an SS 3 branch to keep around before merging this into the master branch.

ggrune commented 6 years ago

There are some other issues with SS4. If you upload new images the files are protected and you have to publish every image in the file management. The images should be public by default.

andrewhoule commented 6 years ago

Gotcha, I'm hoping to get some time to fix it all up soon. Thanks for the head start!

andrewhoule commented 6 years ago

This module now works with SS 4.